Skip to content

Conversation

@fly602
Copy link
Contributor

@fly602 fly602 commented Dec 5, 2025

除dde-login-reminder, 迁移到dde-session-ui中

Log: 移除dde-login-reminder, 迁移到dde-session-ui中

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Debian packaging metadata to add qt6-tools-dev as a build dependency so the package has Qt6 development tools available during build.

File-Level Changes

Change Details Files
Add Qt6 development tools package as a Debian build dependency.
  • Extend the Build-Depends list to include qt6-tools-dev, ensuring Qt6 tooling is present during package builds.
  • Align Debian packaging with current project build requirements that depend on Qt6 tools.
debian/control

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

BLumia
BLumia previously approved these changes Dec 5, 2025
移除dde-login-reminder, 迁移到dde-session-ui中

Log: 移除dde-login-reminder, 迁移到dde-session-ui中
@deepin-ci-robot
Copy link

deepin pr auto review

这个diff显示了一个重大的代码变更:移除了整个dde-login-reminder模块。让我来分析这个变更:

  1. 语法和代码质量:
  • 代码删除操作本身在语法上是正确的
  • 移除的代码看起来组织良好,遵循了Qt和DDE的开发规范
  1. 代码结构:
  • 完整删除了一个独立的工具模块
  • 移除了相关的CMake配置、翻译文件、源代码和配置文件
  • 清理了REUSE.toml中的相关路径配置
  1. 安全性考虑:
  • 移除了密码过期提醒功能可能会带来安全风险
  • 用户将无法及时收到密码即将过期的通知
  • 登录失败提醒功能的缺失可能影响安全审计
  1. 潜在问题:
  • 移除这个功能可能会影响企业环境中的密码管理策略
  • 用户可能无法及时更新密码,导致账户被锁定
  • 失去了登录安全审计的一个重要功能

建议改进:

  1. 如果必须移除这个功能,建议:
  • 在其他地方保留密码过期检查功能
  • 确保系统有其他方式提醒用户密码状态
  • 在系统日志中记录相关的安全事件
  1. 替代方案:
  • 可以考虑将功能集成到其他现有模块中
  • 保留核心安全功能,只移除通知部分
  • 实现更轻量级的替代方案
  1. 文档更新:
  • 需要更新相关文档,说明这个功能已被移除
  • 提供替代的安全管理方案
  • 更新系统配置说明

这个变更看起来是一个重大的功能移除,可能会影响系统的安全性。建议仔细评估这个变更的影响,并确保有适当的替代方案来维护系统的安全功能。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fly602 fly602 changed the title chore: add qt6-tools-dev to build dependencies feat: 移除dde-login-reminder, 迁移到dde-session-ui中 Dec 9, 2025
@fly602 fly602 merged commit abf2399 into linuxdeepin:master Dec 9, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants