Skip to content

Conversation

@yixinshark
Copy link
Contributor

@yixinshark yixinshark commented Jan 4, 2026

Add dde-session-core.target to Conflicts and After directives in dde-session-shutdown.target Ensures proper shutdown order for core session components

Log: add dde-session-core.target dependency to shutdown sequence

Summary by Sourcery

Enhancements:

  • Adjust dde-session-shutdown.target dependencies so it conflicts with and runs after dde-session-core.target for more reliable shutdown ordering.

Add dde-session-core.target to Conflicts and After directives in dde-session-shutdown.target
Ensures proper shutdown order for core session components

Log: add dde-session-core.target dependency to shutdown sequence
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 4, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the systemd shutdown target to explicitly order and conflict with the core session target so that core session components are reliably stopped during shutdown.

File-Level Changes

Change Details Files
Adjust shutdown target dependencies to include dde-session-core.target for correct ordering and conflict handling.
  • Add dde-session-core.target to the Conflicts directive of the dde-session-shutdown target to ensure it is stopped when shutdown begins.
  • Add dde-session-core.target to the After directive of the dde-session-shutdown target so that the shutdown target is only started once the core session target is active, enforcing orderly teardown.
systemd/dde-session-shutdown.target

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

我来对这个git diff进行审查:

  1. 语法逻辑:

    • 修改内容符合systemd target文件的语法规范
    • 新增的dde-session-core.target同时添加到了Conflicts和After部分,保持了配置的一致性
    • 语法上没有问题
  2. 代码质量:

    • 变更逻辑清晰,确保了shutdown target与core target的正确依赖关系
    • 注释保持完整,没有破坏原有的文档说明
    • 代码组织结构合理,遵循了systemd target的标准配置模式
  3. 代码性能:

    • 这个修改不会带来明显的性能影响
    • 只是增加了一个target的依赖关系,不会改变系统的启动/关闭流程的性能特征
  4. 代码安全:

    • 修改是安全的,因为它只是调整了服务间的依赖关系
    • 通过添加dde-session-core.target到Conflicts列表,确保了shutdown时正确处理core target
    • 保持了原有的dbus相关注释,避免了对dbus服务的错误处理

改进建议:

  1. 建议在修改的同时更新相关文档,说明新增的dde-session-core.target的作用
  2. 可以考虑添加注释说明为什么需要将dde-session-core.target添加到依赖关系中
  3. 建议在提交信息中详细说明这个变更的目的和影响

总体来说,这是一个合理的修改,正确处理了系统关闭时的依赖关系,没有发现明显的问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit 64dc88a into linuxdeepin:master Jan 4, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants