-
Notifications
You must be signed in to change notification settings - Fork 30
chore: add dde-session-core.target dependency to shutdown sequence #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add dde-session-core.target dependency to shutdown sequence #184
Conversation
Add dde-session-core.target to Conflicts and After directives in dde-session-shutdown.target Ensures proper shutdown order for core session components Log: add dde-session-core.target dependency to shutdown sequence
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the systemd shutdown target to explicitly order and conflict with the core session target so that core session components are reliably stopped during shutdown. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepin pr auto review我来对这个git diff进行审查:
改进建议:
总体来说,这是一个合理的修改,正确处理了系统关闭时的依赖关系,没有发现明显的问题。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Add dde-session-core.target to Conflicts and After directives in dde-session-shutdown.target Ensures proper shutdown order for core session components
Log: add dde-session-core.target dependency to shutdown sequence
Summary by Sourcery
Enhancements: