Skip to content

Comments

fix(dcc-dock-plugin): dockmode change to alignleft#993

Merged
mhduiy merged 1 commit intolinuxdeepin:masterfrom
mhduiy:fixUi
Dec 24, 2024
Merged

fix(dcc-dock-plugin): dockmode change to alignleft#993
mhduiy merged 1 commit intolinuxdeepin:masterfrom
mhduiy:fixUi

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Dec 24, 2024

pms: TASK-368711

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 将GridLayout更改为Flow布局可能影响布局的预期行为,需要确认这一更改是否符合设计要求。
  • 增加了Layout.margins: 0borderRect,这可能会影响其外观和布局,需要确认这一更改是否符合设计规范。
  • radius属性从12更改为8,这可能会改变矩形的圆角大小,需要确认这一更改是否符合设计要求。
  • font属性被设置为D.DTK.fontManager.t9,需要确认这一字体是否适用于所有平台和语言环境。
  • color属性的条件判断逻辑可能需要优化,以确保在不同状态下颜色显示正确。

是否建议立即修改:

  • 需要确认布局更改是否符合设计要求,并确保不会引入布局问题。
  • 需要验证Layout.margins: 0的更改是否符合设计规范,并可能需要调整其他布局属性以保持一致性。
  • 需要确认radius属性的更改是否符合设计要求,并可能需要调整其他相关属性以保持一致性。
  • 需要确保font属性的更改适用于所有平台和语言环境,并可能需要提供回退方案。
  • 需要优化color属性的条件判断逻辑,以确保在不同状态下颜色显示正确,并可能需要添加注释以解释逻辑。

@mhduiy mhduiy merged commit 837b93f into linuxdeepin:master Dec 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants