Skip to content

Conversation

@dengzhongyuan365-dev
Copy link
Contributor

@dengzhongyuan365-dev dengzhongyuan365-dev commented Jun 19, 2025

update dman's resources

Summary by Sourcery

Update documentation and assets for deepin-compressor’s Archive Manager, and bump the application version.

Enhancements:

  • Restructure English archive‐manager guides into clear "Getting Started" and "Operations Guide" sections, refine wording, table headers, and image formatting.
  • Align and standardize the zh_TW, zh_HK, and zh_CN documentation with the English updates for consistent structure, terminology, and formatting.
  • Add a new close.svg icon asset for the Archive Manager UI.

Build:

  • Bump package version from 6.0.5.1 to 6.0.6.1 in linglong.yaml

- Update dman's resources

log: Update dman's resources.
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dengzhongyuan365-dev - I've reviewed your changes - here's some feedback:

  • The version bump in linglong.yaml to 6.0.6.1 isn’t reflected in the Debian changelog—please update it to keep the release metadata in sync.
  • Section headings use mixed capitalization (Title Case vs. Sentence case); please standardize heading styles across all docs.
  • Make sure the new “Getting Started” section and any structural changes are applied consistently in every localized document (e.g. zh_CN).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The version bump in linglong.yaml to 6.0.6.1 isn’t reflected in the Debian changelog—please update it to keep the release metadata in sync.
- Section headings use mixed capitalization (Title Case vs. Sentence case); please standardize heading styles across all docs.
- Make sure the new “Getting Started” section and any structural changes are applied consistently in every localized document (e.g. zh_CN).

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 19, 2025

Reviewer's Guide

This PR overhauls the Archive Manager documentation across all supported locales, standardizes guide structure and terminology, updates static UI assets, and bumps the application version to 6.0.6.1.

File-Level Changes

Change Details Files
Restructure and unify archive-manager guides
  • Introduce a “Getting Started” section with clear Launch, Close, and Shortcut subsections
  • Consolidate headings and step flows under consistent titles across English and Chinese docs
  • Remove redundant phrasing and harmonize step numbering
  • Align UI labels and menu item names for clarity
src/assets/deepin-compressor/archive-manager/en_US/archive-manager.md
src/assets/deepin-compressor/archive-manager/zh_TW/archive-manager.md
src/assets/deepin-compressor/archive-manager/zh_HK/archive-manager.md
src/assets/deepin-compressor/archive-manager/zh_CN/archive-manager.md
Standardize content formatting and imagery
  • Replace varied Markdown image references with HTML tags and inline styles
  • Refine descriptions of compression options and advanced settings
  • Ensure consistent terminology for actions like Compress, Decompress, View Files
  • Update table headers and bullet formatting for readability
src/assets/deepin-compressor/archive-manager/en_US/archive-manager.md
src/assets/deepin-compressor/archive-manager/zh_TW/archive-manager.md
src/assets/deepin-compressor/archive-manager/zh_HK/archive-manager.md
src/assets/deepin-compressor/archive-manager/zh_CN/archive-manager.md
Update static assets and icons
  • Add new close.svg icon for the exit action
  • Refresh common SVG assets (launcher, compressor, menu icons) to match updated docs
src/assets/deepin-compressor/archive-manager/common/close.svg
src/assets/deepin-compressor/archive-manager/common/deepin_launcher.svg
src/assets/deepin-compressor/archive-manager/common/deepin_compressor.svg
src/assets/deepin-compressor/archive-manager/common/icon_menu.svg
Bump application version
  • Increment version from 6.0.5.1 to 6.0.6.1
linglong.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

TAG Bot

TAG: 6.0.7
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. CMakeLists.txt文件中,新增了对C语言的PIE选项设置,这是一个好的实践,可以提高程序的安全性。但是,建议在添加新的编译选项时,应该先进行充分的测试,确保不会引入新的问题。

  2. linglong.yaml文件中,版本号从6.0.5.1更新到6.0.6.1,这是一个合理的版本更新。但是,建议在更新版本号时,应该确保所有相关的文档和版本控制都已经更新。

  3. src/assets/deepin-compressor/archive-manager/common/close.svg文件中,新增了一个关闭按钮的SVG图标。这是一个好的实践,可以提高用户界面的友好性。但是,建议在添加新的SVG图标时,应该确保图标的尺寸和颜色与整个应用程序的界面风格保持一致。

  4. src/assets/deepin-compressor/archive-manager/common/deepin_compressor.svg文件中,SVG图标的尺寸和视图框(viewBox)属性被修改了。这是一个好的实践,可以提高图标的清晰度和适应性。但是,建议在修改SVG图标时,应该确保图标的尺寸和视图框属性与整个应用程序的界面布局保持一致。

  5. src/assets/deepin-compressor/archive-manager/common/deepin_launcher.svg文件中,SVG图标的尺寸和视图框属性被修改了。这是一个好的实践,可以提高图标的清晰度和适应性。但是,建议在修改SVG图标时,应该确保图标的尺寸和视图框属性与整个应用程序的界面布局保持一致。

  6. src/assets/deepin-compressor/archive-manager/en_US/archive-manager.md文件中,压缩和解压缩操作的说明被更新了。这是一个好的实践,可以提高用户文档的准确性和可读性。但是,建议在更新用户文档时,应该确保文档的内容和格式与整个应用程序的用户界面保持一致。

  7. src/assets/deepin-compressor/archive-manager/zh_CN/archive-manager.md文件中,压缩和解压缩操作的说明被更新了。这是一个好的实践,可以提高用户文档的准确性和可读性。但是,建议在更新用户文档时,应该确保文档的内容和格式与整个应用程序的用户界面保持一致。

  8. src/assets/deepin-compressor/archive-manager/zh_HK/archive-manager.md文件中,压缩和解压缩操作的说明被更新了。这是一个好的实践,可以提高用户文档的准确性和可读性。但是,建议在更新用户文档时,应该确保文档的内容和格式与整个应用程序的用户界面保持一致。

  9. src/assets/deepin-compressor/archive-manager/zh_TW/archive-manager.md文件中,压缩和解压缩操作的说明被更新了。这是一个好的实践,可以提高用户文档的准确性和可读性。但是,建议在更新用户文档时,应该确保文档的内容和格式与整个应用程序的用户界面保持一致。

以上是本次代码提交的主要审查意见,希望能够对您的开发工作有所帮助。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dengzhongyuan365-dev
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 19, 2025

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit e8724af into linuxdeepin:master Jun 19, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants