Skip to content

Conversation

@dengzhongyuan365-dev
Copy link
Contributor

@dengzhongyuan365-dev dengzhongyuan365-dev commented Jun 21, 2025

Summary by Sourcery

Revise and standardize the Archive Manager documentation across all supported locales, reorganize the Getting Started, Operations Guide, and Main Menu sections with updated terminology and formatting, replace Markdown image links with HTML tags, and update build flags and assets.

Enhancements:

  • Reorganize user guide structure with a new "Getting Started" section and clearer subheadings for launching, closing, and shortcuts

Build:

  • Enable -fPIE flag for C sources in CMakeLists.txt

Documentation:

  • Revamp Archive Manager documentation in en_US, zh_TW, zh_HK, and zh_CN with updated tables, terminology, and HTML tags
  • Add new close.svg icon to the common assets

- Update dman's resources

log: Update dman's resources.
- Add -fPIE to CMAKE_C_FLAGS for position-independent code generation.

Log: Update CMake configuration to enhance compatibility.
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 21, 2025

Reviewer's Guide

This PR overhauls the Archive Manager documentation across all locale versions by restructuring sections, unifying formatting and improving wording; adds a new close.svg asset; and updates the CMake build flags to include PIE for C sources.

Flow diagram for CMake build flag update

flowchart TD
    A[Start CMake build]
    B{Is C source?}
    C[Add -fPIE to CMAKE_C_FLAGS]
    D[Continue build process]

    A --> B
    B -- Yes --> C
    C --> D
    B -- No --> D
Loading

File-Level Changes

Change Details Files
Restructure and standardize Archive Manager documentation across English and Chinese locales
  • Reformatted headings and section separators uniformly
  • Introduced “Getting Started” and reorganized operational guides
  • Replaced markdown image syntax with tags and style attributes
  • Normalized table layouts and updated terminology in tables
src/assets/deepin-compressor/archive-manager/en_US/archive-manager.md
src/assets/deepin-compressor/archive-manager/zh_TW/archive-manager.md
src/assets/deepin-compressor/archive-manager/zh_HK/archive-manager.md
src/assets/deepin-compressor/archive-manager/zh_CN/archive-manager.md
Add close.svg asset for use as the close icon
  • Created new close.svg file under common assets
src/assets/deepin-compressor/archive-manager/common/close.svg
Enable PIE for C sources in the build configuration
  • Added CMAKE_C_FLAGS setting to include -fPIE
CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

TAG Bot

TAG: 6.5.6
EXISTED: no
DISTRIBUTION: unstable

@lzwind lzwind merged commit b37de98 into linuxdeepin:develop/snipe Jun 21, 2025
13 of 15 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. CMakeLists.txt文件中,添加了-fPIE标志到CMAKE_C_FLAGS,这是一个好的做法,因为它可以提高程序的安全性。但是,需要确保这个标志在所有目标平台上都适用,并且不会与现有的编译选项冲突。

  2. debian/changelog文件中,添加了一个新的版本发布记录,这是一个好的做法,可以帮助用户了解软件的更新情况。但是,需要确保版本号和发布日期的准确性。

  3. src/assets/deepin-compressor/archive-manager/common/close.svg文件中,添加了一个新的SVG图标文件,这是一个好的做法,可以提高用户界面的美观性。但是,需要确保SVG文件的格式正确,并且与现有的图标风格保持一致。

  4. src/assets/deepin-compressor/archive-manager/common/deepin_compressor.svg文件中,SVG文件的内容被大幅修改,这可能会影响现有的功能和样式。需要确保这些修改是必要的,并且已经通过了充分的测试。

  5. src/assets/deepin-compressor/archive-manager/common/deepin_launcher.svg文件中,SVG文件的内容也被大幅修改,这可能会影响现有的功能和样式。需要确保这些修改是必要的,并且已经通过了充分的测试。

  6. src/assets/deepin-compressor/archive-manager/en_US/archive-manager.md文件中,文档的格式和内容被修改,这可能会影响用户的阅读体验。需要确保这些修改是必要的,并且已经通过了充分的测试。

  7. src/assets/deepin-compressor/archive-manager/zh_CN/archive-manager.md文件中,文档的格式和内容被修改,这可能会影响用户的阅读体验。需要确保这些修改是必要的,并且已经通过了充分的测试。

  8. src/assets/deepin-compressor/archive-manager/zh_HK/archive-manager.md文件中,文档的格式和内容被修改,这可能会影响用户的阅读体验。需要确保这些修改是必要的,并且已经通过了充分的测试。

  9. src/assets/deepin-compressor/archive-manager/zh_TW/archive-manager.md文件中,文档的格式和内容被修改,这可能会影响用户的阅读体验。需要确保这些修改是必要的,并且已经通过了充分的测试。

  10. src/assets/deepin-compressor/archive-manager/zh_TW/fig/hotkey.png文件中,SVG文件的内容被修改,这可能会影响现有的功能和样式。需要确保这些修改是必要的,并且已经通过了充分的测试。

  11. src/assets/deepin-compressor/archive-manager/zh_TW/fig/progress.png文件中,添加了一个新的SVG图标文件,这是一个好的做法,可以提高用户界面的美观性。但是,需要确保SVG文件的格式正确,并且与现有的图标风格保持一致。

总的来说,这些修改都是为了提高软件的功能性和用户体验,但是需要确保这些修改是必要的,并且已经通过了充分的测试。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants