Skip to content

Conversation

@LiHua000
Copy link
Contributor

@LiHua000 LiHua000 commented Dec 25, 2025

Log: as title

Bug: https://pms.uniontech.com/bug-view-345745.html

Summary by Sourcery

Ensure DConfig metadata is available in environments without DTK DConfig support by installing the configuration file directly to the expected dsg configs path when DSG_DATA_DIR is not defined.

Enhancements:

  • Add a fallback installation path for the DConfig JSON config file when DSG_DATA_DIR is not defined in low-version environments.

Build:

  • Update CMake configuration to install the DConfig JSON file into the dsg configs directory when DTK-provided DConfig support is unavailable.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 25, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a fallback installation path for the DConfig JSON metadata file when DSG_DATA_DIR is not defined, ensuring builds work in environments without DTK DConfig support.

Flow diagram for DConfig metadata handling in build system

flowchart TD
    A[Configure build] --> B{DSG_DATA_DIR defined?}
    B -- Yes --> C[Use dconfig_meta_files with APPID and configFile]
    C --> D[DTK DConfig handles metadata installation]
    B -- No --> E[Install configFile to CMAKE_INSTALL_DATADIR/dsg/configs/org.deepin.compressor/]
    E --> F[Metadata available via fallback DSG path]
Loading

File-Level Changes

Change Details Files
Add non-DTK fallback for installing the DConfig config JSON so builds succeed in low-version environments lacking DSG_DATA_DIR.
  • Extend the CMake conditional around DConfig handling to include an else branch when DSG_DATA_DIR is not defined.
  • Install the org.deepin.compressor.method.json config file into CMAKE_INSTALL_DATADIR/dsg/configs/org.deepin.compressor/ for the fallback case.
src/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The hardcoded install path dsg/configs/org.deepin.compressor/ may be brittle; consider deriving the last directory component from APPID or a shared variable so APPID changes don’t require manual path updates.
  • Before using ${CMAKE_INSTALL_DATADIR} in the new branch, ensure it is always defined in all supported environments (e.g., via include(GNUInstallDirs) in a common place) to avoid configuration-time errors in low-version setups.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The hardcoded install path `dsg/configs/org.deepin.compressor/` may be brittle; consider deriving the last directory component from `APPID` or a shared variable so APPID changes don’t require manual path updates.
- Before using `${CMAKE_INSTALL_DATADIR}` in the new branch, ensure it is always defined in all supported environments (e.g., via `include(GNUInstallDirs)` in a common place) to avoid configuration-time errors in low-version setups.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LiHua000, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LiHua000
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit a94aa5f into linuxdeepin:release/eagle Dec 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants