Skip to content

Conversation

@Cryolitia
Copy link
Member

@Cryolitia Cryolitia commented Jul 4, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

  • 检测到debian目录文件有变更: debian/control,debian/rules

@github-actions github-actions bot requested a review from liujianqiang-niu July 4, 2025 01:43
@Cryolitia
Copy link
Member Author

/integr-topic xcb-private

@deepin-ci-robot
Copy link
Contributor

Integrated with pr deepin-community/Repository-Integration#2991

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

  • 检测到debian目录文件有变更: debian/control,debian/rules

debian/rules Outdated

override_dh_auto_configure:
dh_auto_configure -- -DDTK_VERSION=$(PACK_VER)
dh_auto_configure -- -DQT_XCB_PRIVATE_HEADERS=/usr/include/qt6xcb-private
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

路径要不要参照下qt的,
image

@Cryolitia Cryolitia closed this Jul 4, 2025
@Cryolitia Cryolitia reopened this Jul 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

  • 检测到debian目录文件有变更: debian/control,debian/rules

@Cryolitia Cryolitia force-pushed the topic-xcb-private branch from 2d6a1af to 2afbdc4 Compare July 4, 2025 07:44
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

  • 检测到debian目录文件有变更: debian/rules

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, Cryolitia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cryolitia Cryolitia force-pushed the topic-xcb-private branch from 2afbdc4 to fc1ad88 Compare July 8, 2025 04:04
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

  • 检测到debian目录文件有变更: debian/rules

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • debian/rules 文件中移除了 override_dh_auto_configure 目标,可能会影响构建过程,需要确认是否有替代的配置步骤。
  • xcb/linux.cmake 文件中修改了 Qt6 的 include 目录查找逻辑,需要确保新的逻辑不会引入新的问题,并且与现有的构建系统兼容。

是否建议立即修改:

  • 是,需要确认移除 override_dh_auto_configure 是否会影响构建过程,并确保新的 Qt6 include 目录查找逻辑是正确的。

@Cryolitia Cryolitia closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants