Fix checkbox config values always returning "1"#1536
Open
jaycollett wants to merge 1 commit intolinuxserver:2.xfrom
Open
Fix checkbox config values always returning "1"#1536jaycollett wants to merge 1 commit intolinuxserver:2.xfrom
jaycollett wants to merge 1 commit intolinuxserver:2.xfrom
Conversation
The .val() method on checkbox elements returns the value attribute (typically "1") regardless of the checked state. This caused boolean config options like ignore_tls to always be saved as "1" even when the checkbox was unchecked. Fixed by checking if the element is a checkbox and using the :checked state to determine the value. Fixes linuxserver/Heimdall-Apps#782
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where checkbox-type config options (like
ignore_tls) always save as"1"regardless of whether the checkbox is checked or unchecked.Problem
The JavaScript code collecting config values uses
$(this).val()for all form elements. For checkboxes,.val()returns thevalueattribute (typically"1") rather than reflecting the checked state. This means unchecking a boolean config option has no effect - it still saves as"1".Solution
Check if the element is a checkbox and use the
:checkedstate to determine the value:Test plan
ignore_tls)Fixes linuxserver/Heimdall-Apps#782