fix storage monitor race condition#1454
Merged
JosepSampe merged 2 commits intolithops-cloud:masterfrom Jan 22, 2026
Merged
Conversation
Contributor
Author
|
@tomwhite here's the updated PR |
Contributor
|
Thanks @neilSchroeder! @JosepSampe can you take a look please? Thanks! |
Member
|
It looks good to me. However I haven’t had a chance to test it with Cubed—Can we confirm the issue is fixed there with this change? @neilSchroeder Could you fix the linting error in: |
Contributor
Author
|
@JosepSampe I've tested locally with cubed and have confirmed it runs fine. Are there other tests we can run? |
Member
|
@neilSchroeder Thank you for your feedback. The tests for this PR have also run successfully, so I will proceed with merging it. |
Contributor
|
@JosepSampe it would be good to have a release for this if you are planning one soon? |
Member
|
Sure, I’ll release it this week |
Contributor
|
@JosepSampe thank you! |
Member
|
@tomwhite I already created the release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1449
Fixing race condition in
StorageMonitorthat leads to orphaned jobs and indefinite polling.Developer's Certificate of Origin 1.1