Fix: Create meeting call is always a POST request #230
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
============================================
- Coverage 98.73% 98.09% -0.65%
- Complexity 446 454 +8
============================================
Files 52 54 +2
Lines 1027 1049 +22
============================================
+ Hits 1014 1029 +15
- Misses 13 20 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the createMeeting API call was always being sent as a POST request, even when no additional data (presentations or client settings) was being included. The fix ensures that when no modules are present, the request is sent as a GET request instead.
Key Changes:
- Modified
getModules()to return an empty string when no modules (presentations or client settings) are added - Added test coverage for both scenarios: creating a meeting without modules and with presentations/client settings
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Parameters/CreateMeetingParameters.php | Modified getModules() to detect when no modules are added and return an empty string instead of empty XML |
| tests/unit/BigBlueButtonTest.php | Added test cases to verify empty payload for basic meeting creation and XML payload when presentations are included |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
See #229