Fix wrong userReactions feature enum case #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Update feature enum for BBB 3.0" (littleredbutton#225) introduced new cases for the Feature enum. The BBB feature 'userReactions' was mis-spelled and included as 'userActions' (case USER_ACTIONS). Add the correct USER_REACTIONS case with value 'userReactions'. Keep the wrong USER_ACTIONS case to not break existing (changing its value to userReactions is not possible as PHP enums do not allow duplicate values). See https://docs.bigbluebutton.org/development/api/#updates-to-api-in-bigbluebutton
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
============================================
- Coverage 98.73% 98.09% -0.65%
- Complexity 446 454 +8
============================================
Files 52 54 +2
Lines 1027 1049 +22
============================================
+ Hits 1014 1029 +15
- Misses 13 20 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Update feature enum for BBB 3.0" (#225) introduced new cases for the Feature enum.
The BBB feature
userReactionswas mis-spelled and included asuserActions(caseUSER_ACTIONS).Add the correct
USER_REACTIONScase with valueuserReactions.Keep the wrong
USER_ACTIONScase to not break existing (changing its value to userReactions is not possible as PHP enums do not allow duplicate values).See https://docs.bigbluebutton.org/development/api/#updates-to-api-in-bigbluebutton