fix: Enable E2EE for VP9 codec #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cloudwebrtc
requested changes
Jan 7, 2026
Contributor
There was a problem hiding this comment.
For reliability, please enable VP9 only in this PR since AV1 is marked as not yet supported in the JS SDK.
https://github.com/livekit/client-sdk-js/blob/main/src/e2ee/worker/FrameCryptor.ts#L669-L671
Contributor
Author
|
Thanks for the input. I have updated the PR to enable E2EE for VP9 only. Please check again. |
cloudwebrtc
approved these changes
Jan 7, 2026
lib/src/e2ee/e2ee_manager.dart
Outdated
| ..on<TrackSubscribedEvent>((event) async { | ||
| final codec = event.publication.mimeType.split('/')[1]; | ||
| if (event.publication.encryptionType == EncryptionType.kNone || isSVCCodec(codec)) { | ||
| if (event.publication.encryptionType == EncryptionType.kNone) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (event.publication.encryptionType == EncryptionType.kNone) { | |
| if (event.publication.encryptionType == EncryptionType.kNone || codec.toLowerCase() == 'av1') { |
lib/src/e2ee/e2ee_manager.dart
Outdated
| ..on<LocalTrackPublishedEvent>((event) async { | ||
| if (event.publication.encryptionType == EncryptionType.kNone || | ||
| isSVCCodec(event.publication.track?.codec ?? '')) { | ||
| if (event.publication.encryptionType == EncryptionType.kNone) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (event.publication.encryptionType == EncryptionType.kNone) { | |
| if (event.publication.encryptionType == EncryptionType.kNone || | |
| event.publication.track?.codec?.toLowerCase() == 'av1') { |
hiroshihorie
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While using the Flutter SDK with JS SDK and with E2EE enabled, the video from Web can not be decrypted by the Flutter app.
Summary
Enables end-to-end encryption (E2EE) for VP9 codec. Previously, E2EE was skipped for all SVC codecs. This aligns the Flutter SDK with the JS SDK, where E2EE works with VP9 codec.
Changes
Removed
isSVCCodec()and useisAV1Codec()to enable E2EE setup for VP9 codec inLocalTrackPublishedEventhandlerRemoved
isSVCCodec()and useisAV1Codec()to enable E2EE setup for VP9 codec inTrackSubscribedEventhandlerIs there any specific reason why E2EE is disabled for SVC codecs?
I tried VP9 with this patch and the VP9 video from Web can be decrypted by Flutter app.