fix: add protobuf 6.x compatibility #956
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerate proto files with protoc_plugin 25.0.0 which generates code compatible with protobuf 6.x. Changes: - Update protobuf constraint to >=6.0.0 <7.0.0 - Regenerate proto files with newer protoc-gen-dart - Remove local google/protobuf/timestamp.pb.dart (now imported from package:protobuf/well_known_types/) The regenerated files use package:protobuf/well_known_types/ for wellknown types instead of local copies, matching the standard protobuf Dart ecosystem conventions. BREAKING CHANGE: Requires protobuf ^6.0.0. Users on protobuf 4.x will need to upgrade. Closes livekit#955
|
Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Member
|
Thank you for the PR, but I will close this one in favor of #957 (Basically the same) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #955
Summary
Regenerate proto files with
protoc_plugin 25.0.0to add protobuf 6.x compatibility.Changes
>=6.0.0 <7.0.0protoc-gen-dartgoogle/protobuf/timestamp.pb.dart(now imported frompackage:protobuf/well_known_types/)The regenerated files use
package:protobuf/well_known_types/for wellknown types instead of local copies, matching the standard protobuf Dart ecosystem conventions.Breaking Change
Requires protobuf ^6.0.0. Users on protobuf 4.x will need to upgrade.
Testing
All existing tests pass with the regenerated proto files.