fix: hide performance regions with no data #359
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Previously all data returned by the testers was displayed. This commmit changes the behavoir to only display data of regions and pipelines for which the tester did have data.
rickstaa
force-pushed
the
fix/hide-no-performance-data-regions
branch
from
83da5c7 to
730ea27
Compare
|
@ECWireless Since discussions about changing the data endpoint haven’t resulted in an update yet, we could merge this logic into the codebase as a temporary patch, with a clear comment noting that the endpoint still needs to be updated. This would allow us to improve the usability of the performance leaderboard in the meantime. |
There was a problem hiding this comment.
Pull request overview
This pull request enhances the performance leaderboard by filtering out regions and pipelines that lack performance data. The change lifts data fetching to the parent component and implements dynamic region filtering based on available score data.
- Moved performance metrics fetching from
PerformanceListto parentLeaderboardPagecomponent - Added
availableRegionscomputed value that filters regions based on pipeline type and data availability - Refactored
PerformanceListto accept performance metrics as props instead of fetching internally
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pages/leaderboard.tsx | Adds data fetching at page level, implements region filtering logic, and passes performance metrics to child component |
| components/PerformanceList/index.tsx | Refactored to receive performance data via props instead of internal fetching; renamed data prop to orchestratorIds for clarity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Previously all data returned by the testers was displayed. This pull request changes the behavoir to only display data of regions and pipelines for which the tester did have data.