feat: add HorizontalScrollContainer component #469
+115
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
@thebeyondr I created this for my gateway fees dashboard but added it as seperate pull request as it will also help your work on the voting transparency feature. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new reusable HorizontalScrollContainer component designed to improve horizontal scrolling behavior on mobile devices. The component includes a visual gradient indicator when content overflows and can be scrolled.
- Introduces a new component with overflow detection and smooth scrolling behavior
- Replaces inline Box styling with the reusable component in the account layout
- Implements dynamic gradient indicator that appears/disappears based on scroll position
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| components/HorizontalScrollContainer/index.tsx | New component implementing horizontal scroll container with overflow detection via ResizeObserver and scroll events, gradient fade indicator, and ref forwarding |
| layouts/account.tsx | Refactors account tabs to use the new HorizontalScrollContainer component, replacing the previous inline Box implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rickstaa
force-pushed
the
feat/add-horizontalscrollcontainer
branch
from
b064290 to
9420c95
Compare
Adds a reusable component that improves horizontal scrolling behavior on mobile devices.
rickstaa
force-pushed
the
feat/add-horizontalscrollcontainer
branch
from
9420c95 to
371a69c
Compare
Make scrollbuffer a constant to improve code readability. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com
Ensure that the container scrolls to the active page when clicked.
Recalculate overflow effects when child elements change to ensure consistent fading. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rickstaa
force-pushed
the
feat/add-horizontalscrollcontainer
branch
from
6cc6424 to
90e78e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a reusable component that improves horizontal scrolling behavior
on mobile devices.