Skip to content

Conversation

@ashwinb
Copy link
Contributor

@ashwinb ashwinb commented Jan 30, 2025

Having two loggers is confusing. Let's have one.

This change is backward compatible. Older code will continue to work.

API is

for event in EventStreamPrinter.gen(inference.chat_completion(...):
   event.print()

Test Plan

$ llama-stack-client inference chat-completion --message "Hi how are you" --stream
Assistant> I'm just a language model, I don't have emotions or feelings like humans do, but I'm functioning properly and ready to help with any questions or tasks you may have! How about you? How's your day going so far?
$
cd llama-stack/tests/client-sdk
LLAMA_STACK_BASE_URL=http://localhost:8321 pytest -s -v agents/test_agents.py -k agent_simple

@ashwinb ashwinb merged commit 28b93d0 into main Jan 30, 2025
2 checks passed
@ashwinb ashwinb deleted the loggers branch January 30, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants