Skip to content

Conversation

@vladimirivic
Copy link
Contributor

What does this PR do?

We are updating ENV var names to follow shorter naming pattern, the env vars will be prefixed by LLAMA_STACK instead of LLAMA_STACK_CLIENT which was previously auto-generated by Stainless by reading the project name field in the spec, but Stainless added a new feature where we can override this prefix.

Test Plan

export LLAMA_STACK_BASE_URL=<base-url>
export LLAMA_STACK_API_KEY=<api-key>
from llama_stack_client import LlamaStackClient
client = LlamaStackClient()

# will create a client pointing to <base-url>, with <api-key>.

Copy link
Member

@raghotham raghotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably allow for both env vars and deprecate the older one - this is not a backward compatible change

@ashwinb
Copy link
Contributor

ashwinb commented Feb 21, 2025

this code is auto-generated @raghotham

@ashwinb
Copy link
Contributor

ashwinb commented Feb 21, 2025

unless we do more work, you aren't going to get back-compat. I don't think this one is worth it at all.

@vladimirivic
Copy link
Contributor Author

vladimirivic commented Feb 21, 2025

I could extend the sync script and add a manual modification of lines like os.environ.get("LLAMA_STACK_API_KEY") to try the new then the old env var and we keep that for a while. I evaluated the risk of breaking things was small but we can be extra cautious if we think there is a chance something breaks.

Copy link
Member

@raghotham raghotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@raghotham
Copy link
Member

Not needed. Overwritten by #157

@raghotham raghotham closed this Feb 21, 2025
@ashwinb ashwinb deleted the update-env-var-names branch August 14, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants