Skip to content

fix: more types in client_tool type conversion #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehhuang wants to merge 1 commit into from
Closed

fix: more types in client_tool type conversion #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/llama_stack_client/lib/agents/client_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,14 @@ def async_run_impl(self, **kwargs):

T = TypeVar("T", bound=Callable)

# python typehint to litellm/openai parameter spec
TYPEHINT_TO_LITELLM_TYPE = {
"int": "integer",
"float": "number",
"bool": "boolean",
"str": "string",
}


def client_tool(func: T) -> ClientTool:
"""
Expand Down Expand Up @@ -197,8 +205,7 @@ def get_params_definition(self) -> Dict[str, Parameter]:
params[name] = Parameter(
name=name,
description=param_doc or f"Parameter {name}",
# Hack: litellm/openai expects "string" for str type
parameter_type=type_hint.__name__ if type_hint.__name__ != "str" else "string",
parameter_type=TYPEHINT_TO_LITELLM_TYPE.get(type_hint.__name__, type_hint.__name__),
default=(param.default if param.default != inspect.Parameter.empty else None),
required=is_required,
)
Expand Down