Skip to content

Conversation

@Ald392
Copy link

@Ald392 Ald392 commented Mar 12, 2025

What does this PR do?

Fixes the type of tool_params in the default react agent prompt

(Closes #194)

@facebook-github-bot
Copy link
Contributor

Hi @Ald392!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Ald392
Copy link
Author

Ald392 commented Mar 14, 2025

hello @yanxi0830, is there any specific reason #200 was picked and mine was not. Will be helpful to understand the reason, so that i could take care of it in the future.

@ehhuang
Copy link
Contributor

ehhuang commented Mar 14, 2025

hello @yanxi0830, is there any specific reason #200 was picked and mine was not. Will be helpful to understand the reason, so that i could take care of it in the future.

Sorry I completely missed this PR! My apologies.

@Ald392
Copy link
Author

Ald392 commented Mar 14, 2025

hello @yanxi0830, is there any specific reason #200 was picked and mine was not. Will be helpful to understand the reason, so that i could take care of it in the future.

Sorry I completely missed this PR! My apologies.

No issues.
Closing the PR since the issue is resolved by #200

@Ald392 Ald392 closed this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReAct Agent Default prompt has the wrong type for tool_params

3 participants