feat: provider update #219
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add v1/providers/ client handling which uses PUT to allow users to change their provider configuration
this is a follow up to #1429 and related to #1359
a user can call something like:
llama_stack_client.providers.update(api="inference", provider_id="ollama", provider_type="remote::ollama", config={'url': 'http:/localhost:12345'})
or
llama-stack-client providers update inference ollama remote::ollama "{'url': 'http://localhost:12345'}"
this API works by adding a RequestMiddleware to the server which checks requests, and if the user is using PUT /v1/providers, the routes are re-registered with the re-initialized provider configurations/methods
Signed-off-by: Charlie Doern <cdoern@redhat.com>
cdoern
requested review from
SLR722,
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
raghotham,
vladimirivic and
yanxi0830
as code owners
|
@cdoern you're going to want to close this and reopen it in https://github.com/llamastack/llama-stack-client-python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add v1/providers/ client handling which uses PUT to allow users to change their provider configuration
this is a follow up to #1429 and related to #1359
a user can call something like:
llama_stack_client.providers.update(api="inference", provider_id="ollama", provider_type="remote::ollama", config={'url': 'http:/localhost:12345'})
or
llama-stack-client providers update inference ollama remote::ollama "{'url': 'http://localhost:12345'}"
this API works by adding a RequestMiddleware to the server which checks requests, and if the user is using PUT /v1/providers, the routes are re-registered with the re-initialized provider configurations/methods
Test Plan
see llamastack/llama-stack#1905