Skip to content

fix: model register missing model-type and not accepting metadata #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bobbins228 wants to merge 1 commit into from
Closed

fix: model register missing model-type and not accepting metadata #252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/llama_stack_client/lib/cli/models/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# This source code is licensed under the terms described in the LICENSE file in
# the root directory of this source tree.

import json
from typing import Optional

import click
Expand Down Expand Up @@ -99,6 +100,7 @@ def get_model(ctx, model_id: str):
@click.option("--provider-id", help="Provider ID for the model", default=None)
@click.option("--provider-model-id", help="Provider's model ID", default=None)
@click.option("--metadata", help="JSON metadata for the model", default=None)
@click.option("--model-type", help="Model type", default="llm")
Copy link
Member

@raghotham raghotham Jul 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the allowed values for Model type in the help.

@click.pass_context
@handle_client_errors("register model")
def register_model(
Expand All @@ -107,16 +109,29 @@ def register_model(
provider_id: Optional[str],
provider_model_id: Optional[str],
metadata: Optional[str],
model_type: Optional[str],
):
"""Register a new model at distribution endpoint"""
client = ctx.obj["client"]
console = Console()

# Parse metadata JSON string to dictionary if provided
parsed_metadata = None
if metadata:
try:
parsed_metadata = json.loads(metadata)
except json.JSONDecodeError as e:
console.print(
f"[red]Error parsing metadata JSON: {e}[/red]"
)
return

response = client.models.register(
model_id=model_id,
provider_id=provider_id,
provider_model_id=provider_model_id,
metadata=metadata,
metadata=parsed_metadata,
model_type=model_type,
)
if response:
console.print(f"[green]Successfully registered model {model_id}[/green]")
Expand Down