chore!: remove the agents (sessions and turns) API #4055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the API, which was marked alpha in 0.3.0 and now is being removed. It is completely superseded by the Responses + Conversations APIs and our client-SDK Agent class is already updated to use those implementations. This PR performs a cleanup of dependent types and tests as well.
ashwinb
requested review from
bbrowning,
ehhuang,
franciscojavierarceo,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
franciscojavierarceo
approved these changes
Nov 4, 2025
bbrowning
approved these changes
Nov 4, 2025
ashwinb
added a commit
to ashwinb/llama-stack
that referenced
this pull request
Nov 7, 2025
llamastack#4055 cleaned the agents implementation but while doing so it removed some tests which actually corresponded to the responses implementation. This PR brings those tests and assocated recordings back. (We should likely combine all responses tests into one suite, but that is beyond the scope of this PR.)
leseb
pushed a commit
that referenced
this pull request
Nov 7, 2025
#4055 cleaned the agents implementation but while doing so it removed some tests which actually corresponded to the responses implementation. This PR brings those tests and assocated recordings back. (We should likely combine all responses tests into one suite, but that is beyond the scope of this PR.)
ashwinb
pushed a commit
that referenced
this pull request
Nov 14, 2025
# What does this PR do? Restores the responses unit tests that were inadvertently deleted in PR [#4055 ](#4055) ## Test Plan I ran the unit tests that I restored. They all passed with one exception: tests/unit/providers/agents/meta_reference/test_openai_responses.py::test_reuse_mcp_tool_list AttributeError: module 'llama_stack.providers.utils.tools' has no attribute 'mcp' It's coming from this line: @patch("llama_stack.providers.utils.tools.mcp.list_mcp_tools") The mcp.py module (and \_\_init\_\_.py) exists under tools. There are some 'from mcp ....' imports (mcp package in this case) within it that python may be interpreting as circular imports (or maybe I'm overlooking something).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SessionNotFoundErrorandAgentTurnInputTypewhich are no longer neededThe agents API is completely superseded by the Responses + Conversations APIs, and the client SDK Agent class already uses those implementations.
Corresponding client-side PR: llamastack/llama-stack-client-python#295