feat(new provider): Adding OCI 26ai Vector Support #4411
Conversation
rriley99-oci
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
| @@ -0,0 +1,342 @@ | |||
| { | |||
| "cells": [ | |||
There was a problem hiding this comment.
Do we need a notebook for this? Can't we jsut put this in the regular docs?
There was a problem hiding this comment.
@franciscojavierarceo we've been chatting with @omaryashraf5 about this a bit, notebooks aren't necessarily needed but are much nicer to follow as a guarantee of correct setup than a document. I'd be curious to hear your thoughts.
There was a problem hiding this comment.
Yeah I would say that a broader notebook should be fine but vector stores behave approximately equivalently for all providers so we wouldn't need one specific to OCI 26ai, but we could have specific documentation to outline important implementation details.
raghotham
changed the title
raghotham
changed the title
|
This pull request has merge conflicts that must be resolved before it can be merged. @rriley99-oci please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
3 participants
What does this PR do?
This is a draft so I can ask some questions for now. I will remove "DRAFT" when its ready for review.
Test Plan