-
Notifications
You must be signed in to change notification settings - Fork 623
[BAZEL] Update the Bazel overlay to use MODULE #4398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi, @sjain-stanford the wiki listed you as the maintainer for the bazel build. Could you review this PR? Thanks. |
| llvm_config.with_system_environment(["HOME", "INCLUDE", "LIB", "TMP", "TEMP"]) | ||
|
|
||
| # llvm_config.use_default_substitutions() | ||
| llvm_config.use_default_substitutions() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for FileCheck substitution using @LLVM_TOOLS_DIR@
Thanks for the ping. I am no longer overseeing the bazel build for torch-mlir but let me loop in someone who can help. |
WORKSPACE are deprecated and to be replaced by MODULE. Bazel roadmap mentions WORKSPACE are going to be removed entirely. Mainline LLVM has also upgraded from WORKSPACE to MODULE.
This PR updates the Torch-MLIR overlay to use MODULE and fixes the bazel build.
.bazelversionto 8.4.0 (parity with mainline LLVM)AArch64target to the LLVM Build (to support local builds on Arm)