-
Notifications
You must be signed in to change notification settings - Fork 0
Handle container startup failures #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Image string | ||
| Name string | ||
| Port string | ||
| HealthPath string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to configure multiple ports yet, so simplified and made Port a string instead of a map to keep things simple
|
|
||
| test-integration: build | ||
| cd test/integration && go test -v . | ||
| cd test/integration && go test -count=1 -v . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This disables test caching.
❯ go help testflag | grep "disable test caching" -C 2
When 'go test' runs in package list mode, 'go test' caches successful
package test results to avoid unnecessary repeated running of tests. To
disable test caching, use any test flag or argument other than the
cacheable flags. The idiomatic way to disable test caching explicitly
is to use -count=1.
|
|
||
| onProgress := func(msg string) { | ||
| fmt.Println(msg) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The onProgress callback decouples the business logic from how output is displayed. Without it, the internal/container package would need to import and depend on UI (bubbletea).
cmd/tointernal/container/How to test
make test-integrationpasses./bin/lstk startshows license errorSample output:
toward DRG-352