Chore: Correct and verify type hints in manager.py #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
commented
Jan 30, 2026
| """ | ||
| try: | ||
| return func(*args) | ||
| func(*args, **{}) |
Author
There was a problem hiding this comment.
None of the invocations of _call_safe do anything with the result, so I think this is a safe refactor/improvement
bblommers
commented
Jan 30, 2026
| def test_lifecycle_listener(self, dummy_plugin_finder): | ||
| listener = MagicMock() | ||
| def test_lifecycle_listener(self, dummy_plugin_finder: DummyPluginFinder) -> None: | ||
| listener = Mock() |
Author
There was a problem hiding this comment.
In the PluginManager I also made this change:
- if isinstance(listener, (list, set, tuple)):
+ if isinstance(listener, Iterable):Turns out that MagicMock is an instance of Iterable - so that suddenly changed the logic, and cause the test to fail. Using a basic Mock does not have this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
PluginManageralready had decent type hints - this PR improves them a bit and adds support formypyto verify that they are all correct.Note that I added type hints to the test as well, just to verify the type hints of the
PluginManageritself are correct when invoking the class.Ideally I'd like to get to a point where we add types to the entire code base, just to make it a little easier to use downstream. When we get to that point, we can add the
py.typedfile as well.