fix(android): nested scroll breaks after conditional ScrollView remount#564
Merged
fix(android): nested scroll breaks after conditional ScrollView remount#564
Conversation
Detect content hierarchy changes via OnHierarchyChangeListener and re-run setupScrollable + requestLayout when the pinned ScrollView is no longer a descendant. Removes redundant cachedScrollView field.
Refactor iOS delegate chain to match Android pattern: - ContentView checks if ScrollView changed before notifying delegate - Extract applyScrollViewBottomInset helper to reduce duplication - Track keyboard height in TrueSheetKeyboardObserver for re-application
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
🚀 This pull request is included in v3.9.7. See Release 3.9.7 for release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the first-interaction bug where remounting a nested ScrollView (e.g. conditional rendering) causes the sheet to drag instead of scroll. Resolves #563.
addView/removeViewAton Android andmountChildComponentView/unmountChildComponentViewon iOSsetupScrollableflow and inset helpers across both platformscurrentHeightto iOSTrueSheetKeyboardObserverfor keyboard state trackingType of Change
Test Plan
Checklist