-
Notifications
You must be signed in to change notification settings - Fork 1
SP-2402: NB 300 series on variable stars #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,800 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(by using, e.g., [f]_psfFluxSigma, or some combination of the flux value percentiles from [f]_psfFluxPercentile05, 25, 50, 75, 95). We will also use r_psfFluxStetsonJ, which reports the Stetson J-index, an indicator of periodic variability.
Maybe move the first sentence to be outside of parenthesis, to be consistent with the Stetson J-index sentence.
Reply via ReviewNB
| @@ -0,0 +1,800 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add "applied in TAP query" to the line on r_scienceFluxMean, to be consistent with the point above it. Or remove both conditions from the list since they were already applied.
Reply via ReviewNB
| @@ -0,0 +1,800 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe how we measure the period via Lomb-Scargle, and how the LC is phased.
Seems like this got left behind as a self-reminder
Reply via ReviewNB
| @@ -0,0 +1,800 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The light curve that appears the least periodic, for diaObjectId 614435616184074318 seems to be classified as a quasar. I was hoping it would be obviously different within the 4 highlighted objects in the plots in section 2.3, but not sure how to exclude it yet.
Reply via ReviewNB
No description provided.