added GitHub CI and other minor edits eyeing Lua 5.5

[luau-project]

Changes

• Replaced Travis CI by GitHub CI
• README
  • Replaced Travis CI badge by GitHub CI badge
  • Used https scheme on luarocks link
  • Used lunarmodules on busted link

Notes

1. Ideally, this PR should be merged after rockspec: bump max lua version #33;
2. CI for Lua 5.5 will keep failing until these other PRs (support Lua 5.5 cluacov#7 and fix(lua55): loop variables are constants now lunarmodules/luacov#118) get merged, and new versions of cluacov and luacov get published on LuaRocks website;

Important

For the codecov badge to work correctly, a GitHub secret (named CODECOV_TOKEN) has to be added to hold the codecov token.

[Aire-One]

Luacheck supports GitHub Actions: https://github.com/lunarmodules/luacheck?tab=readme-ov-file#use-as-a-ci-job

[Aire-One]

As a general good practice / security measure, I think @master should never be used, and we should have pined version (using sha rather than tags)

[luau-project]

I agree with you on that matter. However, if you inspect other projects led by Hisham, you can see that he employs actions from the default branch most of the times.

• LuaRocks:

  • https://github.com/luarocks/luarocks/blob/ab7fbdec3f6fd9e5fa55d355580e0bfbece73140/.github/workflows/test.yml#L20-L25
  • https://github.com/luarocks/luarocks/blob/ab7fbdec3f6fd9e5fa55d355580e0bfbece73140/.github/workflows/test.yml#L35-L51
  • https://github.com/luarocks/luarocks/blob/ab7fbdec3f6fd9e5fa55d355580e0bfbece73140/.github/workflows/test.yml#L95-L103
  • https://github.com/luarocks/luarocks/blob/ab7fbdec3f6fd9e5fa55d355580e0bfbece73140/.github/workflows/test.yml#L111-L119

• Teal: https://github.com/teal-language/tl/blob/72a3182ff20f27601ba4ac0ca281dbc1ddbcbb1b/.github/workflows/ci.yml#L23-L30

• cluacov: https://github.com/luarocks/cluacov/blob/e81e0f9edac19790ca8d057e9fcf7ddf7d1a6fcc/.github/workflows/test.yml#L18-L29

So, I'm following his patterns on his repositories. If he (or any repo admin) requests it to be changed to a pinned commit SHA strategy, for sure I'll do.

[Aire-One]

Thank you for the clarification!

[Aire-One]

Busted supports GitHub Actions: https://github.com/lunarmodules/busted?tab=readme-ov-file#use-as-a-ci-job

[luau-project]

For the sake of completeness, I'm going to link here an important comment written by myself regarding Lua 5.5 support: #32 (comment)

[daurnimator]

For the codecov badge to work correctly, a GitHub secret (named CODECOV_TOKEN) has to be added to hold the codecov token.

Done.

[daurnimator]

Looks like an improvement on the status quo to me

[daurnimator]

It appears that cluacov doesn't support lua 5.5 yet:

src/cluacov/deepactivelines.c:18:2: error: #error unsupported Lua version
   18 | #error unsupported Lua version
      |  ^~~~~
src/cluacov/deepactivelines.c:35:8: error: unknown type name ‘Proto’
   35 | static Proto *get_proto(lua_State *L) {
      |        ^~~~~
src/cluacov/deepactivelines.c: In function ‘get_proto’:
src/cluacov/deepactivelines.c:36:14: error: ‘Closure’ undeclared (first use in this function)
   36 |     return ((Closure *) lua_topointer(L, 1))->l.p;
      |              ^~~~~~~
src/cluacov/deepactivelines.c:36:14: note: each undeclared identifier is reported only once for each function it appears in
src/cluacov/deepactivelines.c:36:23: error: expected expression before ‘)’ token
   36 |     return ((Closure *) lua_topointer(L, 1))->l.p;
      |                       ^
src/cluacov/deepactivelines.c: At top level:
src/cluacov/deepactivelines.c:150:43: error: unknown type name ‘Proto’
  150 | static void add_activelines(lua_State *L, Proto *proto) {
      |                                           ^~~~~
src/cluacov/deepactivelines.c: In function ‘l_deepactivelines’:
src/cluacov/deepactivelines.c:221:5: warning: implicit declaration of function ‘add_activelines’; did you mean ‘l_deepactivelines’? [-Wimplicit-function-declaration]
  221 |     add_activelines(L, get_proto(L));
      |     ^~~~~~~~~~~~~~~
      |     l_deepactivelines

Error: Build error: Failed compiling object src/cluacov/deepactivelines.o

[daurnimator]

It appears that cluacov doesn't support lua 5.5 yet:

luarocks/cluacov#7

[luau-project]

In the comment #32 (comment), I explained what has to be done (the set of PRs to be merged) for argparse tests pass for Lua 5.5. I think it is worth a read / review.