Skip to content

Conversation

@Mansi-mParticle
Copy link
Collaborator

Background

  • The SDK currently uses a mix of logging approaches, including printStackTrace(), which is not aligned with our recommended logging pattern. As noted in the internal guidance, all developer-facing logs should go through the Logger class to ensure consistency and proper log handling.

What Has Changed

  • Replaced e.printStackTrace() with Logger.error(e) to follow the standard logging approach.

Screenshots/Video

  • {Include any screenshots or video demonstrating the new feature or fix, if applicable}

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • {Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle requested a review from a team as a code owner December 4, 2025 21:43
@Mansi-mParticle Mansi-mParticle force-pushed the fix/SDKE-674-migrate-generic-logs-to-logger branch from ec87e70 to 64867e2 Compare December 4, 2025 21:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

thomson-t
thomson-t previously approved these changes Dec 5, 2025
jamesnrokt
jamesnrokt previously approved these changes Dec 9, 2025
Signed-off-by: Mansi-mParticle <159845845+Mansi-mParticle@users.noreply.github.com>
@Mansi-mParticle Mansi-mParticle dismissed stale reviews from jamesnrokt and thomson-t via d65b8e8 January 13, 2026 16:30
@sonarqubecloud
Copy link

@Mansi-mParticle Mansi-mParticle merged commit 9c9cb33 into main Jan 13, 2026
17 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/SDKE-674-migrate-generic-logs-to-logger branch January 13, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants