refactor: remove MPListenerController code #495
+30
−922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denischilik
force-pushed
the
refactor/remove-MPListenerController-code
branch
from
33510e8 to
17161bb
Compare
nickolas-dimitrakas
force-pushed
the
refactor/remove-MPListenerController-code
branch
2 times, most recently
from
ba60c17 to
80c54bc
Compare
- need to move MPEndpoint and MPDatabaseTable enums to their own files - need to remove MPListenerProtocol from headers
- MPListener stubs become uncalled and unused upon deletion of the MPListenerController class - substituted for a time based wait
nickolas-dimitrakas
force-pushed
the
refactor/remove-MPListenerController-code
branch
from
38b1031 to
5b42ed7
Compare
BrandonStalnaker
requested changes
Jan 20, 2026
Collaborator
BrandonStalnaker
left a comment
BrandonStalnaker
left a comment
There was a problem hiding this comment.
Looks good in general. One thing stood out on a quick pass through
BrandonStalnaker
approved these changes
Jan 20, 2026
Collaborator
BrandonStalnaker
left a comment
BrandonStalnaker
left a comment
There was a problem hiding this comment.
LGTM but you might want to get a review from Denis too with this IntegrationTests changes
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
MPListenerControllersystem from the SDK as part of a refactoring effort to simplify the codebase. The listener system was a debugging/monitoring API that allowed customers to receive callbacks for SDK operations, but is no longer needed. This is a breaking change that removes public APIs.What Has Changed
MPListenerProtocolMPListenerControllerimports from headersEventUploadWaiterChecklist
Reference Issue (For employees only. Ignore if you are an outside contributor)