Skip to content

test: Add Unit Tests for Persistence Module #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
alexs-mparticle wants to merge 11 commits into
base: development
Choose a base branch
from
Draft

test: Add Unit Tests for Persistence Module #335

alexs-mparticle wants to merge 11 commits into from

Conversation

@alexs-mparticle
Copy link
Collaborator

@alexs-mparticle alexs-mparticle commented Aug 16, 2022

Summary

  • Add unit tests for Persistence so we can test individual methods

Master Issue

Closes https://go.mparticle.com/work/SQDSDKS-4431

@alexs-mparticle alexs-mparticle changed the base branch from master to development August 16, 2022 21:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

alexs-mparticle
alexs-mparticle commented Aug 17, 2022
View reviewed changes
src/persistence.js Outdated
try {
storage.setItem('mparticle', 'test');
result = storage.getItem('mparticle') === 'test';
storage.getItem('mparticle') === 'test';
Copy link
Collaborator Author

@alexs-mparticle alexs-mparticle Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
storage.getItem('mparticle') === 'test';
var result = storage.getItem('mparticle') === 'test';

alexs-mparticle
alexs-mparticle commented Aug 17, 2022
View reviewed changes
src/persistence.js Outdated
storage.getItem('mparticle') === 'test';
storage.removeItem('mparticle');
return result && storage;
return true;
Copy link
Collaborator Author

@alexs-mparticle alexs-mparticle Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return true;
return result;

@alexs-mparticle alexs-mparticle added the refactor Changes to the structure of the code label Aug 24, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 36 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 37 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexs-mparticle alexs-mparticle force-pushed the development branch 3 times, most recently from e715974 to 6f1f758 Compare February 6, 2023 23:05
@alexs-mparticle alexs-mparticle force-pushed the test/SQDSDKS-4431-add-persistence-unit-tests branch from 0406bea to 91b23fe Compare February 15, 2023 17:35
@alexs-mparticle alexs-mparticle force-pushed the test/SQDSDKS-4431-add-persistence-unit-tests branch from 91b23fe to 65c785c Compare February 21, 2023 15:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexs-mparticle alexs-mparticle force-pushed the development branch 2 times, most recently from 1fdcd41 to 029f51e Compare May 15, 2023 17:37
@rmi22186 rmi22186 closed this Sep 22, 2023
@rmi22186 rmi22186 reopened this Sep 22, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 172 Code Smells

No Coverage information No Coverage information
25.2% 25.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@alexs-mparticle alexs-mparticle force-pushed the development branch 3 times, most recently from 8d955f2 to 3f4f268 Compare January 2, 2024 17:15
@alexs-mparticle alexs-mparticle removed the refactor Changes to the structure of the code label Sep 11, 2024
@rmi22186 rmi22186 force-pushed the development branch 5 times, most recently from 905641c to b16bdd2 Compare December 10, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backlog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexs-mparticle @rmi22186