Parameterise execution of runner

[kpturner]

No description provided.

[esteve]

@kpturner thanks for your PR. I've added your fork to https://github.com/esteve/autoware_packages/blob/main/.github/workflows/generate-debs-aws.yml#L21 but I can't seem to get the CI workflow to run as the ubuntu user (https://github.com/esteve/autoware_packages/blob/main/.github/workflows/generate-debs-aws.yml#L29-L30), is there anything that needs fixing in the workflow configuration?

[esteve]

Forgot to link to a CI run (https://pipelines.actions.githubusercontent.com/serviceHosts/0571ff26-7fc8-4c97-8abd-f4480660739f/_apis/pipelines/1/runs/50/signedlogcontent/9?urlExpires=2023-05-03T11%3A18%3A46.7515461Z&urlSigningMethod=HMACV1&urlSignature=ff1ZpjWGpqtpPIOMonwu7zpYjPok%2BVFiRIzjtMTUG94%3D). I added a bunch of commands (whoami, id, etc) to the Debug step to check what user the action is running as, but it's root anyway, can't get it to switch to the ubuntu user.

[esteve]

Never mind, I just realized that your PR doesn't have an up to date ./dist/index.js. After running npm run package and rebasing on top of main (https://github.com/esteve/ec2-github-runner/tree/Optionally-execute-runner-as-a-service), and attempting to run an action as ubuntu, the CI workflow gets stuck waiting for the EC2 instance to register on GitHub (see https://pipelines.actions.githubusercontent.com/serviceHosts/0571ff26-7fc8-4c97-8abd-f4480660739f/_apis/pipelines/1/runs/69/signedlogcontent/2?urlExpires=2023-05-03T13%3A39%3A00.4783305Z&urlSigningMethod=HMACV1&urlSignature=5cm9sDE4hEd%2F5KqxUYvc3RmZHzvsvUa9YRzFwP6UAcw%3D)

Is there a way to fix this? Thanks.

[esteve]

Found the issue that made it not work in my case. If runner-home-dir is empty (i.e. we let the action download the runner code), but we set run-as-user, this won't work because chown expects two arguments. I fixed it by replacing ${config.input.runnerHomeDir} with ., which works because the current directory is already set earlier in cd "${config.input.runnerHomeDir}" or mkdir actions-runner && cd actions-runner

[esteve]

@kpturner I've committed the fix I mentioned in #122 (comment) in my fork (https://github.com/esteve/ec2-github-runner/tree/Optionally-execute-runner-as-a-service). I've also rebased your changes on top of main and ran npm run package to update dist/index.js, since the changes to src/aws.js and dist/index.js in this PR were not in sync.

[Flyingliuhub]

any update on this? we need this for run as non-root. thanks

[alonbl]

Hi,
It would be great to run workfow as non-root similar to github environment. There are tools which are failing when running as root.
Also have the ability to select where the workspace is, so it can be redirected to a different filesystem.
Thanks,

[esteve]

@Flyingliuhub @alonbl I've been updating this PR on top of main in #152 , which also contains a couple of fixes. We've been using these change at the Autoware Foundation for a while (see https://github.com/autowarefoundation/autoware-deb-packages)