Conversation
8c80cf4 to
31def49
Compare
There was a problem hiding this comment.
Pull request overview
This pull request upgrades PostGraphile from version 1.x to version 5 (2.0.0-beta.1), representing a major version upgrade that modernizes the GraphQL API service configuration. The changes involve removing the old JavaScript-based configuration file in favor of environment variable-based configuration, updating Docker images, adjusting Traefik routing rules, and introducing new data volumes for the service.
Changes:
- Upgraded PostGraphile to v5 (beta) with new Docker images (maevsi/postgraphile:2.0.0-beta.1 for production, :dev for development)
- Removed .postgraphilerc.js configuration file and migrated to environment variable-based configuration via file mounts in /run/environment-variables/
- Modified Traefik routing: GraphQL API now requires explicit /graphql path, GraphiQL interface accessible at root domain path
- Added postgraphile_data volume for node_modules and development workspace volumes for local development
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| src/production/production.yml | Updated PostGraphile image to version 2.0.0-beta.1 for production deployment |
| src/production/configurations/postgraphile/.postgraphilerc.js | Removed old JavaScript configuration file (no longer used in v5) |
| src/development/stack.yml | Major refactoring: updated image to :dev, changed port from 5000 to 5678, modified secrets mounting to /run/environment-variables/, swapped Traefik routing rules, added development volumes |
| README.md | Added documentation for new postgraphile_data volume |
Comments suppressed due to low confidence (1)
src/production/configurations/postgraphile/.postgraphilerc.js:1
- The old configuration file (.postgraphilerc.js) included several important settings that are not explicitly configured in the new setup:
- defaultRole: 'vibetype_anonymous'
- dynamicJson: true
- enhanceGraphiql: true
- extendedErrors: ['errcode']
- ignoreRBAC: false
- jwtTokenIdentifier: 'vibetype.jwt'
- schema: ['vibetype']
- setofFunctionsContainNulls: false
- watch: true
- appendPlugins: [postgisPlugin]
Verify that the new PostGraphile v5 container handles these configurations either through environment variables, new defaults, or that they are no longer needed in v5. If these settings are still required, they need to be provided through the new configuration mechanism.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
31def49 to
0113383
Compare
This pull request updates the PostGraphile service configuration for both development and production environments, focusing on modernizing the setup, improving environment variable handling, and updating data volume management. The changes also include the removal of the old PostGraphile configuration file and adjustments to Traefik routing rules.