#4 - Config changes - Item Name, Item Path, quality and improvements #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of changes: - Introduced `ITEM_PATH` constant in `ActivityInterface` to define the new property. - Added `getItemPath()` and `setItemPath()` methods to `Activity` model for retrieving and setting `item_path`. - Updated `ActivityInterface` with declarations for the `item_path` getter and setter methods.
List of changes: - Updated `db_schema.xml` to include a new nullable `item_path` column in the admin activity log table. - Modified `db_schema_whitelist.json` to allow the `item_path` field. - Added relevant comments to describe the new `item_path` column purpose.
…in Activity Log List of changes: - Added `Structure`, `Section`, and `Group` dependencies to `SystemConfig` for handling configuration structure. - Introduced `getHumanReadablePath` method in `SystemConfig` to generate a user-friendly path for system configuration fields. - Injected `SystemConfig` into `Processor` to leverage the new path functionality. - Updated `Processor` to populate `item_path` with the human-readable configuration path for system configuration logs. - Enhanced logging to differentiate `item_name` and `item_path` for better clarity.
List of changes: - Updated `admin_activity_listing.xml` to include a new `item_path` column with `Path` label. - Configured the `item_path` column with text filtering and validation for required entry. - Adjusted column comments for improved clarity.
List of changes: - Reorganized constructor parameters in `ActivityLogListing` to include optional `JsonHelper` and `DirectoryHelper`. - Added type hints and return types (`?array`, `array<string, string>`) to methods for improved type safety. - Refactored `getAdminDetails` to use array shorthand, enhancing code readability. - Updated docblocks to align with new method signatures and type annotations. - Introduced `path` key in `getAdminDetails` output to include the `item_path` property for logs.
List of changes: - Updated `log_listing.phtml` to include a new row displaying the `Path` detail from `adminDetails`. - Applied consistent styling to match existing rows for `Path`, including font size and weight adjustments. - Removed an unnecessary blank line before variable declarations for better readability.
List of changes: - Introduced `ActivityLogListingTest` to test the core functionality of the `ActivityLogListing` block. - Added `testGetLogListingActivityFound`, `testGetLogListingActivityNotFound`, and `testGetLogListingActivityNullableId` to validate `getLogListing` logic for various scenarios. - Implemented `testGetAdminDetails` for verifying correct output of admin details, including username, module, and human-readable path. - Created `testGetActivityRepository` to ensure the correct instance is returned for activity repository. - Mocked required dependencies, such as `Activity`, `Collection`, `Browser`, and repository interfaces, to simulate realistic behavior.
List of changes: - Updated `log_listing.phtml` to include new rows for `Scope` and `Store` details from `adminDetails`. - Enhanced `getAdminDetails` in `ActivityLogListing` block to provide `scope` and `store_name` values. - Added logic in `getAdminDetails` to format the `store_name` as a human-readable string, including website, group, and store names. - Included `NoSuchEntityException` handling in case of invalid store references. - Applied consistent styling for `Scope` and `Store` details in the UI table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.