locking/unlocking #3
Conversation
Locking and unlocking of topic instances.
|
Question: should we also have a |
| /** | ||
| * Check if the current topic is locked. | ||
| */ | ||
| public async isLocked(state: mage.core.IState = new mage.core.State()) { |
There was a problem hiding this comment.
Not sure about TypeScript, but in ES (afaik) if you return a Promise, you should not mark your function async.
There was a problem hiding this comment.
It doesn't matter: if you return a promise on an async call, then that promise will be the promise to be returned.
tslint is currently configured to request that functions returning promises or otherwise using await require the async keyword. I believe this is for readability purposes (e.g. when checking the function signature), but also to make sure that whatever you return is a promise.
There was a problem hiding this comment.
Do you know if that is true for ES as well?
2 participants
Locking and unlocking of topic instances.
cc @ronkorving @AlmirKadric feedback welcome.