Skip to content

Conversation

@gaalferov
Copy link
Collaborator

@gaalferov gaalferov commented Jan 15, 2026

Motivation

PR #59 from external contributor (Benjamin-fr) was merged into this feature branch for final CI validation, as fork PRs require manual workflow approval for security reasons. All tests have been executed successfully.

Related: #59

Changes

  • Added Symfony 8.0 support to version constraints in composer.json:
    • symfony/mime: ^6.0|^7.0|^8.0
    • symfony/http-client: ^6.0|^7.0|^8.0 (dev)
    • symfony/mailer: ^6.0|^7.0|^8.0 (dev)
  • Extended CI test matrix with Symfony 8 + PHP 8.4 combination
  • Extended CI test matrix with PHP 8.5 combination

How to test

All CI jobs passing (19 test jobs total):

  • PHP 8.0, 8.1, 8.2, 8.3, 8.4 with latest dependencies
  • Symfony 6 (PHP 8.2), Symfony 7 (PHP 8.3, 8.4), Symfony 8 (PHP 8.4)
  • Laravel 9, 10, 11, 12 compatibility
  • Psalm static analysis on all PHP versions
composer test

Summary by CodeRabbit

  • Chores
    • Added support for Symfony 8 on PHP 8.4 and PHP 8.5.
    • Extended CI to run tests against Symfony 8 on PHP 8.4 and PHP 8.5.
    • Relaxed dependency constraints to allow Symfony 8 for runtime and relevant dev packages.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

📝 Walkthrough

Walkthrough

Adds Symfony 8 compatibility: expands composer.json Symfony dependency constraints to include ^8.0 and updates the CI PHPUnit matrix to add Symfony 8 test entries (including PHP 8.4 and PHP 8.5).

Changes

Cohort / File(s) Summary
CI / Test Configuration
​.github/workflows/ci-phpunit.yml
Added Symfony 8 entries to the test matrix; added PHP 8.5 to the PHP matrix and added Symfony 8 coverage rows (PHP 8.4 and PHP 8.5).
Dependency Management
composer.json
Broadened Symfony-related constraints to include ^8.0 for symfony/mime (require) and symfony/http-client, symfony/mailer (require-dev).

Sequence Diagram(s)

(omitted — changes are CI and dependency updates without multi-component runtime control flow)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • leonid-shevtsov
  • i7an
  • VladimirTaytor
  • mklocek

Poem

🐰 A new eight hops into the sun,
Composer stretched, the tests now run,
Matrix rows bloom, the build's begun,
Dependencies dance, one by one,
Rabbit cheers — compatibility won! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add symfony 8' is concise and clearly describes the main change in the pull request: adding Symfony 8 support to the project.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description covers all required sections with detailed motivation, comprehensive changes list, and specific test results.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gaalferov gaalferov marked this pull request as ready for review January 15, 2026 14:41
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/ci-phpunit.yml:
- Around line 69-70: The job name template currently appends "LTS"
unconditionally (e.g., "Symfony ${{ matrix.symfony }} LTS"), which mislabels
Symfony 8; update the job name template to only append "LTS" when matrix.symfony
is an LTS release (e.g., when matrix.symfony == '6' or '7') or remove the "LTS"
suffix entirely; change the job name expression that uses matrix.symfony so it
conditionally includes the " LTS" suffix for the LTS versions only.
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac49b00 and d077b7b.

📒 Files selected for processing (2)
  • .github/workflows/ci-phpunit.yml
  • composer.json
🔇 Additional comments (1)
composer.json (1)

16-16: Dependency constraints are correct for Symfony 8 support.

Version constraints properly extend compatibility to Symfony 8.x. Composer will automatically resolve to Symfony 7.x for PHP 8.0–8.3 (since Symfony 8 requires PHP 8.4+) and Symfony 8.x for PHP 8.4+, maintaining backward compatibility across the board.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

@gaalferov gaalferov merged commit 306d117 into main Jan 15, 2026
22 checks passed
@gaalferov gaalferov deleted the feature/add-symfony-8 branch January 15, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants