-
Notifications
You must be signed in to change notification settings - Fork 13
Add symfony 8 #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add symfony 8 #60
Conversation
📝 WalkthroughWalkthroughAdds Symfony 8 compatibility: expands composer.json Symfony dependency constraints to include ^8.0 and updates the CI PHPUnit matrix to add Symfony 8 test entries (including PHP 8.4 and PHP 8.5). Changes
Sequence Diagram(s)(omitted — changes are CI and dependency updates without multi-component runtime control flow) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/ci-phpunit.yml:
- Around line 69-70: The job name template currently appends "LTS"
unconditionally (e.g., "Symfony ${{ matrix.symfony }} LTS"), which mislabels
Symfony 8; update the job name template to only append "LTS" when matrix.symfony
is an LTS release (e.g., when matrix.symfony == '6' or '7') or remove the "LTS"
suffix entirely; change the job name expression that uses matrix.symfony so it
conditionally includes the " LTS" suffix for the LTS versions only.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci-phpunit.ymlcomposer.json
🔇 Additional comments (1)
composer.json (1)
16-16: Dependency constraints are correct for Symfony 8 support.Version constraints properly extend compatibility to Symfony 8.x. Composer will automatically resolve to Symfony 7.x for PHP 8.0–8.3 (since Symfony 8 requires PHP 8.4+) and Symfony 8.x for PHP 8.4+, maintaining backward compatibility across the board.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Motivation
PR #59 from external contributor (Benjamin-fr) was merged into this feature branch for final CI validation, as fork PRs require manual workflow approval for security reasons. All tests have been executed successfully.
Related: #59
Changes
composer.json:symfony/mime:^6.0|^7.0|^8.0symfony/http-client:^6.0|^7.0|^8.0(dev)symfony/mailer:^6.0|^7.0|^8.0(dev)How to test
All CI jobs passing (19 test jobs total):
composer testSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.