Skip to content
This repository was archived by the owner on Apr 17, 2020. It is now read-only.

Conversation

@kiwiupover
Copy link
Contributor

Looks like this addon is really stable and could be bumped to 1.0
What else needs to be done to move ember-cli-deploy-webhooks to 1.0?

This PR bumps the version to 1.0.0-beta.1
Can we cut a npm release for this.

Thanks for maintaining this project.

Cheers
Dave

@marcoow
Copy link
Member

marcoow commented Oct 4, 2018

I'm all 👍 for releasing 1.0. I do think we should address #27 before that though.

@kiwiupover
Copy link
Contributor Author

#28 addressed #27 and #22

So both #27 and @22 can be closed.

I can change this PR to be the 1.0.0 if you would like.

Cheers

@marcoow
Copy link
Member

marcoow commented Oct 4, 2018

Ah perfect, I'm closing those then. Let's release 1.0.0-beta.1 for now and then update to 1.0.0 if no flood of issues comes in over the next few weeks or so.

@kiwiupover
Copy link
Contributor Author

kiwiupover commented Oct 4, 2018 via email

@marcoow marcoow merged commit 8d47d64 into mainmatter:master Oct 4, 2018
@kiwiupover
Copy link
Contributor Author

@marcoow what is the best way to push this to NPM?
If can do that if you want I'm kiwiupover on npmjs.org

https://www.npmjs.com/~kiwiupover

Cheers
Dave

@kiwiupover kiwiupover deleted the bump-version branch October 4, 2018 17:50
@marcoow
Copy link
Member

marcoow commented Oct 5, 2018

I pushed already; though we should have this running as part of the Travis build for master ideally… /cc @Turbo87

@kiwiupover
Copy link
Contributor Author

@marcoow Thanks for pushing the beta to npm!
😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants