Skip to content
This repository was archived by the owner on Apr 17, 2020. It is now read-only.

Conversation

@marcoow
Copy link
Member

@marcoow marcoow commented Nov 9, 2018

Doing all these updates before releasing 1.0 as some updates might technically be considered breaking changes (I think ember-cli-babel is technically breaking?)

@marcoow marcoow requested a review from mansona November 9, 2018 14:59
mansona
mansona previously approved these changes Apr 9, 2020
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good 🤔 I'm not too familiar with the project itself but I checked and there are at least some tests so I am assuming if there was anything that's using lodash it is exercised in there and we would catch any issues 👍

@mansona mansona dismissed their stale review April 9, 2020 08:01

As it turns out the tests are failing 😂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants