This repository was archived by the owner on Mar 31, 2025. It is now read-only.
Add custom exception for error responses #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunny
force-pushed
the
custom-error-response
branch
from
0f1359c to
b0d02de
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Makerbot team and happy new year! ✨
This fixes a
TODOin the code to raise a custom exception when there is an unhandled HTTP response error, allowing for more easy debug and understanding.This also fixes when the gem would
raise "#{response.code}: #{JSON.parse(response.body)['error']}"without testing if the body is in JSON or not, therefore raising aJSON::ParserErrorinstead of a helpful error message.