fix: use min_clip parameter for y-axis lower bound in plot_fst_gwss_track#910
Open
Tanisha127 wants to merge 4 commits intomalariagen:masterfrom
Open
fix: use min_clip parameter for y-axis lower bound in plot_fst_gwss_track#910Tanisha127 wants to merge 4 commits intomalariagen:masterfrom
Tanisha127 wants to merge 4 commits intomalariagen:masterfrom
Conversation
Author
|
Hi, I’ve updated this PR to improve the y-axis ticker logic so that 0 is retained when clip_min is non-zero (using sorted(set([clip_min, 0, 1]))). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the y-axis lower bound handling in
plot_fst_gwss_track.Previously, the lower bound was not correctly using the
min_clipparameter.This change ensures that the y-axis minimum is properly controlled by
min_clip.Changes
min_clipTesting