Improvements to contributing guide#927
Open
jwgarber wants to merge 1 commit intomalariagen:masterfrom
Open
Conversation
1. Many systems have different default python versions, so use poetry to install the CI-tested version. 2. Install poetry dependencies with `--extras dev` to allow running pytest. 3. Restore instructions about logging into Gcloud to run integration tests. 4. Add command about checking types with mypy.
jwgarber
force-pushed
the
update-contributing-guide
branch
from
9d739a1 to
3662807
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few fixes and improvements from running through the contributor guide.
--extras devto allow running pytest.I applied for access to Google cloud and will run through the integration tests once that's accepted. Also, for the python versions, I noticed that 3.10 and 3.12 are both used in the CI workflows, I imagine it'd be ok to update everything to 3.12?