Skip to content

Conversation

@kmadsen
Copy link
Contributor

@kmadsen kmadsen commented Sep 14, 2022

Description

Addressing #6141

After removing MapboxNavigation from CarActiveGuidanceCarContext and fixing up ActiveGuidanceScreen, it was clear that we no longer need CarActiveGuidanceCarContext so this is deleting it 🎉

This also moves the PlacesListOnMapLayerUtil out of the constructor. We may want to add marker customizations but this is not how we can do it. Anything we want to do there can be handled first by the new CarActiveGuidanceMarkers.

Adding CarArrivalTrigger as a definition for what to do when the arrival happen. It was in the ActiveGuidanceScreen, but moving it to a separate class will make it easy for us to integrate into the installer #6211

I'm opening this now and would be happy to merge it. Otherwise I'll add tests to the new classes because that logic does not have any coverage.

@kmadsen kmadsen requested a review from a team as a code owner September 14, 2022 02:24
@kmadsen kmadsen changed the title Remove MapboxNavigation instance from ActiveGuidanceScreen [Android Auto] Remove MapboxNavigation instance from ActiveGuidanceScreen Sep 14, 2022
@kmadsen kmadsen force-pushed the km-remove-mapboxnavigation-ActiveGuidanceScreen branch 2 times, most recently from ccddef8 to a759374 Compare September 14, 2022 02:30
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #6326 (1dc164d) into main (1dc164d) will not change coverage.
The diff coverage is n/a.

❗ Current head 1dc164d differs from pull request most recent head a0abb34. Consider uploading reports for the commit a0abb34 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6326   +/-   ##
=========================================
  Coverage     68.88%   68.88%           
  Complexity     4504     4504           
=========================================
  Files           681      681           
  Lines         27002    27002           
  Branches       3162     3162           
=========================================
  Hits          18601    18601           
  Misses         7182     7182           
  Partials       1219     1219           

@kmadsen kmadsen force-pushed the km-remove-mapboxnavigation-ActiveGuidanceScreen branch from a759374 to 54d7daf Compare September 14, 2022 20:40
@kmadsen kmadsen force-pushed the km-remove-mapboxnavigation-ActiveGuidanceScreen branch 2 times, most recently from fffadb0 to c5880e0 Compare September 15, 2022 20:09
@kmadsen kmadsen force-pushed the km-remove-mapboxnavigation-ActiveGuidanceScreen branch from c5880e0 to a0abb34 Compare September 15, 2022 22:11
@kmadsen kmadsen added the Android Auto Bugs, improvements and feature requests on Android Auto. label Sep 15, 2022
@kmadsen kmadsen merged commit 6394564 into main Sep 15, 2022
@kmadsen kmadsen deleted the km-remove-mapboxnavigation-ActiveGuidanceScreen branch September 15, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android Auto Bugs, improvements and feature requests on Android Auto.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants