[AndroidAuto] Migrate CarRouteRequest to MapboxNavigationApp

[kmadsen]

Description

Addressing #6141

This needs to be done before this one #6371

Migrating CarRouteRequest to use MapboxNavigationObserver

[codecov]

Codecov Report

Merging #6372 (185dd0e) into main (df05b41) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #6372   +/-   ##
=========================================
  Coverage     68.95%   68.95%           
  Complexity     4579     4579           
=========================================
  Files           691      691           
  Lines         27382    27382           
  Branches       3191     3191           
=========================================
  Hits          18881    18881           
  Misses         7262     7262           
  Partials       1239     1239           

[Zayankovsky]

Should we use !! here?

[kmadsen]

I thought about this a lot, and established an opinion. I agree with you that there should be a signal that the request did not happen. But I'm hesitant with crashing here. Considering that this is just one new type of many possible failures. I think the error should be sent to CarRouteRequestCallback. So for now it's sending it to onNoRoutesFound

[kmadsen]

Arguable that this is a developer error so it should crash. But there are other developer errors that will not crash, for example if the interceptor provides impossible parameters.

Also you may want to request routes from things that are not lifecycle aware. The CarRouteRequest is lifecycle aware so the caller does not have to be 🤔

object SomeUtility {
--snip--
  fun goToNextDestination(placeRecord) {
    MapboxNavigationApp.getObserver(CarRouteRequest::class).request(placeRecord, callback)
  }
}

[kmadsen]

And then the reason why it's good to always have a callback respond. Is because otherwise people will build "infinite spinners"

// simplified version of the callback to illustrate the point.
// stopLoading would not be called if the `CarRouteRequest` is detached.
spinner.startLoading()
MapboxNavigationApp.getObserver(CarRouteRequest::class).request(placeRecord) {
  spinner.stopLoading()
}