-
Notifications
You must be signed in to change notification settings - Fork 319
Rename to getRegisteredInstance #6445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c975fa to
020a57c
Compare
ad4cc8d to
ddda20f
Compare
kmadsen
commented
Oct 5, 2022
kmadsen
commented
Oct 5, 2022
kmadsen
commented
Oct 5, 2022
libnavui-voice/src/main/java/com/mapbox/navigation/ui/voice/api/MapboxAudioGuidance.kt
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #6445 +/- ##
=========================================
Coverage 69.31% 69.31%
Complexity 4730 4730
=========================================
Files 703 703
Lines 27759 27760 +1
Branches 3274 3274
=========================================
+ Hits 19242 19243 +1
Misses 7226 7226
Partials 1291 1291
|
Contributor
Author
|
oh gosh i forgot about the license needing to be changed a bunch whenever there is a change to these dependencies |
Zayankovsky
reviewed
Oct 6, 2022
...roidauto/src/main/java/com/mapbox/androidauto/navigation/audioguidance/AppAudioGuidanceUi.kt
Outdated
Show resolved
Hide resolved
81e72f4 to
efe955a
Compare
Zayankovsky
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Android Auto
Bugs, improvements and feature requests on Android Auto.
UI
Work related to visual components, Android Auto, Camera, 3D, voice, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
MapboxAudioGuidanceinstance is going to be part of the2.9.0stable release train. So this is settling on a naming convention to use in a few places #6420 (comment)We are also updating a different incompatibility for this release. So the
qa-test-appdoes not see the runtime crash during development. This will all be resolved after a release and then updating theui-androidautoto use the new release.