Skip to content

Conversation

@kmadsen
Copy link
Contributor

@kmadsen kmadsen commented Oct 5, 2022

Description

The MapboxAudioGuidance instance is going to be part of the 2.9.0 stable release train. So this is settling on a naming convention to use in a few places #6420 (comment)

We are also updating a different incompatibility for this release. So the qa-test-app does not see the runtime crash during development. This will all be resolved after a release and then updating the ui-androidauto to use the new release.

@kmadsen kmadsen force-pushed the km-rename-to-getRegisteredInstance branch 2 times, most recently from 0c975fa to 020a57c Compare October 5, 2022 21:16
@kmadsen kmadsen marked this pull request as ready for review October 5, 2022 21:16
@kmadsen kmadsen requested a review from a team as a code owner October 5, 2022 21:16
@kmadsen kmadsen force-pushed the km-rename-to-getRegisteredInstance branch from ad4cc8d to ddda20f Compare October 5, 2022 22:19
@kmadsen kmadsen added Android Auto Bugs, improvements and feature requests on Android Auto. UI Work related to visual components, Android Auto, Camera, 3D, voice, etc. labels Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #6445 (efe955a) into main (cf2980c) will increase coverage by 0.00%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6445   +/-   ##
=========================================
  Coverage     69.31%   69.31%           
  Complexity     4730     4730           
=========================================
  Files           703      703           
  Lines         27759    27760    +1     
  Branches       3274     3274           
=========================================
+ Hits          19242    19243    +1     
  Misses         7226     7226           
  Partials       1291     1291           
Impacted Files Coverage Δ
...igation/ui/voice/view/MapboxAudioGuidanceButton.kt 72.36% <33.33%> (ø)
...box/navigation/ui/voice/api/MapboxAudioGuidance.kt 79.68% <50.00%> (ø)
.../voice/internal/ui/AudioGuidanceButtonComponent.kt 93.93% <66.66%> (+0.18%) ⬆️
...nternal/controller/AudioGuidanceStateController.kt 77.27% <100.00%> (ø)

@kmadsen
Copy link
Contributor Author

kmadsen commented Oct 5, 2022

oh gosh i forgot about the license needing to be changed a bunch whenever there is a change to these dependencies

@kmadsen kmadsen enabled auto-merge (squash) October 6, 2022 01:14
@kmadsen kmadsen force-pushed the km-rename-to-getRegisteredInstance branch from 81e72f4 to efe955a Compare October 6, 2022 15:01
@kmadsen kmadsen merged commit 56e02b6 into main Oct 6, 2022
@kmadsen kmadsen deleted the km-rename-to-getRegisteredInstance branch October 6, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android Auto Bugs, improvements and feature requests on Android Auto. UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants