-
Notifications
You must be signed in to change notification settings - Fork 319
Bump sdk dependencies #6833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sdk dependencies #6833
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| - Added `RoadComponent.language` value. | ||
| - :warning: Changed `EHorizonEdgeMetadata.names` class from `RoadName` to `RoadComponent`. | ||
| To migrate change your code from: | ||
| ```kotlin | ||
| val shielded = roadName.shielded | ||
| ``` | ||
| into: | ||
| ```kotlin | ||
| val shielded = roadComponent.shield != null | ||
| ``` | ||
| - Added support for continuous EV alternatives in `NavigationRouteAlternativesObserver`. | ||
| - Fixed issues with map-matching to HOV-only roads. | ||
| - Set a limit of simultaneously running onboard route requests to avoid too many tasks blocking too much of the device's computing resources. | ||
| - Fixed an issue with Road Access Policy ignoring the setting to map-match to closed road sections, when enabled. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -615,9 +615,11 @@ package com.mapbox.navigation.base.road.model { | |
|
|
||
| public final class RoadComponent { | ||
| method public String? getImageBaseUrl(); | ||
| method public String getLanguage(); | ||
| method public com.mapbox.api.directions.v5.models.MapboxShield? getShield(); | ||
| method public String getText(); | ||
| property public final String? imageBaseUrl; | ||
| property public final String language; | ||
| property public final com.mapbox.api.directions.v5.models.MapboxShield? shield; | ||
| property public final String text; | ||
| } | ||
|
|
@@ -1020,7 +1022,7 @@ package com.mapbox.navigation.base.trip.model.eh { | |
| method public double getLength(); | ||
| method public Double? getMeanElevation(); | ||
| method public boolean getMotorway(); | ||
| method public java.util.List<com.mapbox.navigation.base.trip.model.eh.RoadName> getNames(); | ||
| method public java.util.List<com.mapbox.navigation.base.road.model.RoadComponent> getNames(); | ||
| method public boolean getRamp(); | ||
| method public String getRoadSurface(); | ||
| method public double getSpeed(); | ||
|
|
@@ -1044,7 +1046,7 @@ package com.mapbox.navigation.base.trip.model.eh { | |
| property public final double length; | ||
| property public final Double? meanElevation; | ||
| property public final boolean motorway; | ||
| property public final java.util.List<com.mapbox.navigation.base.trip.model.eh.RoadName> names; | ||
| property public final java.util.List<com.mapbox.navigation.base.road.model.RoadComponent> names; | ||
| property public final boolean ramp; | ||
| property public final String roadSurface; | ||
| property public final double speed; | ||
|
|
@@ -1156,13 +1158,6 @@ package com.mapbox.navigation.base.trip.model.eh { | |
| @StringDef({com.mapbox.navigation.base.trip.model.eh.RoadClass.MOTORWAY, com.mapbox.navigation.base.trip.model.eh.RoadClass.TRUNK, com.mapbox.navigation.base.trip.model.eh.RoadClass.PRIMARY, com.mapbox.navigation.base.trip.model.eh.RoadClass.SECONDARY, com.mapbox.navigation.base.trip.model.eh.RoadClass.TERTIARY, com.mapbox.navigation.base.trip.model.eh.RoadClass.UNCLASSIFIED, com.mapbox.navigation.base.trip.model.eh.RoadClass.RESIDENTIAL, com.mapbox.navigation.base.trip.model.eh.RoadClass.SERVICE_OTHER}) @kotlin.annotation.Retention(kotlin.annotation.AnnotationRetention.BINARY) public static @interface RoadClass.Type { | ||
| } | ||
|
|
||
| public final class RoadName { | ||
| method public String getName(); | ||
| method public boolean getShielded(); | ||
| property public final String name; | ||
| property public final boolean shielded; | ||
| } | ||
|
|
||
|
Comment on lines
-1159
to
-1165
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we fine with these breaking changes?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's EHorizon only, and it's in beta, so I think we are ok
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not experimental. I don't think it's OK.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dzinad we don't have
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alright then. We should have added the annotation.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's fix it separately https://mapbox.atlassian.net/browse/NAVSDK-835 |
||
| public final class RoadSurface { | ||
| field public static final String COMPACTED = "COMPACTED"; | ||
| field public static final String DIRT = "DIRT"; | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, this way it will be easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we're done with CI, in this case we can skip this. We can always address when composing final changelog.