Skip to content

bump NN to 123.3.1, Common to 23.2.2, Maps to 10.10.1 #6871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dzinad wants to merge 3 commits into from
Closed

bump NN to 123.3.1, Common to 23.2.2, Maps to 10.10.1 #6871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2cb46d
bump NN to 123.3.1, Common to 23.2.2, Maps to 10.10.1
dzinad Jan 26, 2023
68f6cc7
Rename changelog files
Jan 27, 2023
68c9e1c
clarified distance to start accuracy
VysotskiVadim Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/features/6871.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Added custom header x-mapbox-app-info to requests.
- Fix upcoming route alerts incorrect position.
- Stabilized routes with alternatives refresh / re-route on deviate.
6 changes: 3 additions & 3 deletions gradle/dependencies.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ ext {
// version which we should use in this build
def mapboxNavigatorVersion = System.getenv("FORCE_MAPBOX_NAVIGATION_NATIVE_VERSION")
if (mapboxNavigatorVersion == null || mapboxNavigatorVersion == '') {
mapboxNavigatorVersion = '123.2.0'
mapboxNavigatorVersion = '123.3.1'
}
println("Navigation Native version: " + mapboxNavigatorVersion)

version = [
mapboxMapSdk : '10.10.0',
mapboxMapSdk : '10.10.1',
mapboxSdkServices : '6.10.0',
mapboxNavigator : "${mapboxNavigatorVersion}",
mapboxCommonNative : '23.2.1',
mapboxCommonNative : '23.2.2',
mapboxCrashMonitor : '2.0.0',
mapboxAnnotationPlugin : '0.8.0',
mapboxBaseAndroid : '0.8.0',
Expand Down
7 changes: 3 additions & 4 deletions ...oidTest/java/com/mapbox/navigation/instrumentation_tests/core/UpcomingRouteObjectsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import com.mapbox.navigation.testing.ui.utils.runOnMainSync
import kotlinx.coroutines.flow.first
import org.junit.Assert.assertEquals
import org.junit.Before
import org.junit.Ignore
import org.junit.Rule
import org.junit.Test
import java.net.URI
Expand Down Expand Up @@ -55,7 +54,6 @@ class UpcomingRouteObjectsTest : BaseTest<EmptyTestActivity>(EmptyTestActivity::
}

@Test
@Ignore("waiting for the NN fix, see NN-449")
fun distanceToIncidentDoesNotChangeAfterAddingNewWaypointOnTheRouteGeometry() = sdkTest {
val (oneLegRoute, twoLegsRoute, incidentId) =
getRoutesFromTheSameOriginButDifferentWaypointsCount()
Expand All @@ -76,8 +74,9 @@ class UpcomingRouteObjectsTest : BaseTest<EmptyTestActivity>(EmptyTestActivity::
.first { it.roadObject.id == incidentId }

assertEquals(
upcomingIncidentForOneLeg.distanceToStart,
upcomingIncidentForTwoLegsRoute.distanceToStart
upcomingIncidentForOneLeg.distanceToStart!!,
upcomingIncidentForTwoLegsRoute.distanceToStart!!,
0.1
)
}

Expand Down