Fix for a race condition in the usage of URLCache#4821
Open
Fix for a race condition in the usage of URLCache#4821
Conversation
maru-biz
commented
Feb 19, 2026
maru-biz
force-pushed
the
mr/urldatacache-fix
branch
2 times, most recently
from
047f593 to
b98e7e3
Compare
# Conflicts: # CHANGELOG.md
maru-biz
force-pushed
the
mr/urldatacache-fix
branch
from
b98e7e3 to
d8a47d0
Compare
kried
reviewed
Feb 23, 2026
Sources/MapboxNavigation/Cache.swift
Outdated
| @@ -47,6 +47,7 @@ internal class URLDataCache: URLCaching { | |||
|
|
|||
| let urlCache: URLCache | |||
Contributor
There was a problem hiding this comment.
Should we also mark the property as private to avoid accidentional access?
kried
reviewed
Feb 24, 2026
| */ | ||
| internal class URLDataCache: URLCaching { | ||
| let defaultDiskCacheURL: URL = { | ||
| private static var defaultDiskCacheURL: URL { |
Contributor
There was a problem hiding this comment.
Are there any reasons to make it a var?
I don't see any usage of it in the pull request now. I assume it might be needed in tests for cleanup, but for such cases, you can either pass a non-nil diskCacheURL value to the initializer or clean up the default folder directly.
Contributor
Author
There was a problem hiding this comment.
It is used in init (only), so I've changed it to computed property.
kried
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a randomly occurring race condition in the usage of
URLCache.Implementation
URLCachereads/writes.updateMapStylewhich was able to provoke a race condition.Screenshots or Gifs