Do not play reroute sound on alternatives switch#4822
Open
Conversation
Udumft
reviewed
Feb 20, 2026
| routeOptions: options, | ||
| isProactive: false, | ||
| isAlternative: false) { [weak self] _ in | ||
| reason: .reroute) { [weak self] _ in |
Contributor
There was a problem hiding this comment.
How does it detect if the reroute was previously detected (user has wandered off route) or if this reroute comes from invalidating alternative routes?
Contributor
Author
There was a problem hiding this comment.
No such reroutes can happen in the v2 Nav SDK v2. This pull request only fixes the beep sound played on alternative switching, with reason: .alternative, e.g. the one happens here in rerouteControllerWantsSwitchToAlternative
| @@ -1,5 +1,15 @@ | |||
| # Changes to the Mapbox Navigation SDK for iOS | |||
|
|
|||
| ## v2.21.0 | |||
Contributor
There was a problem hiding this comment.
So, do we make a minor release in the end?
Contributor
Author
There was a problem hiding this comment.
This pull request contains a new public constant, so it can be released only in a minor release
kried
force-pushed
the
NAVIOS-2513
branch
2 times, most recently
from
49fb27e to
330a091
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue introduced in #4808 related to the reroute sound when switching to an alternative route