Update build system for latest versions of Node#39
Update build system for latest versions of Node#39mwilsnd wants to merge 4 commits intomapbox:masterfrom mwilsnd:update
Conversation
|
@mourner, any chance to push this through so we can update our dependencies to latest? The dependencies update is currently blocked due to dependencies misalignment which creates an increase in bundle size... |
|
Apologies — I'm off this week but perhaps @kkaefer you could take a quick look? From my side this looks good |
|
This is from yesterday, no rush, just wanted to make sure it gets the relevant attention... |
|
@mourner this is a gentle reminder. |
|
Let's proceed here: |
|
This is unfortunate that we need to create a fork in order to push this forward. |
This PR swaps out mason and node-gyp for a CMake+submodules approach instead, unblocking use with newer node versions. Updates to
vt-pbfare currently blocked by this module, see the MapLibre issue: maplibre/maplibre-gl-js#4393cmakeandzlibare required to build. Both tests in this module and invt-pbf(when using this PR) appear to be passing. Sincenode-pre-gypandmasonwere removed, there's no longer any pre-built binary distribution functionality.It's unclear to me what else I might be missing but it seems moving to CMake was, at least at one point, under consideration for these older modules? See mapbox/vtcomposite#140
cc. @HarelM